[kdenlive] New feature "force breeze icon theme"... should it be default?

[Narcis Garcia]

My (not solid) way to detect KDE session in a ShellScript:

Desktop="$(echo "$DESKTOP_SESSION" | tr '[:upper:]' '[:lower:]')"
if [ "$(echo "$Desktop" | grep -ie 'default')" != "" ] ; then
	SManager="$(cat /etc/X11/default-display-manager 2>/dev/null)"
	SManager="$(basename "$SManager")"
	case "$SManager" in
		"kdm" )	Desktop="kde" ;;
	esac
fi
if [ "$(echo "$Desktop" | grep -e '^kde')" ] ; then
	Desktop="kde"
fi



El 27/06/16 a les 23:05, Jean-Baptiste Mardelle ha escrit:
> On Monday, June 27, 2016 9:19:09 PM CEST, farid abdelnour wrote:
>> Hi Jesse and all
>>
>> A bit late but I think this should be enabled by default and also add
>> breeze icons as a dependency. First because the breeze icons are the
>> "recommended" way Kdenlive is supposed to look like (If one doesn't
>> like it he/she have the choice to change it in the settings.) Secondly
>> because not all icon themes provide all the icons which are in
>> Kdenlive's interface making it look buggy.
>>
>> Cheers
> 
> 
> Hi all,
> 
> Trying to catch on... my idea was that on first run (or when the config
> file is deleted), to detect if user is using a KDE Desktop, and if not,
> enable the "Force Breeze" option by default. However I have not yet
> found a simple reliable way to check that but should be possible.
> If you still encounter issues with icons on git master (missing icons,
> wrong colors, etc), please report the issues and tell me which Desktop
> environment you use (Gnome, etc) and which KDE Frameworks version you
> have - check for libkf5xmlgui package version.
> 
> By the way, adding a "Use dark color theme" to the Wizard seems a nice
> idea (I also plan to refactor the Wizard so that it only has one
> friendly page and no more annoying clicks to really start the app).
> 
> Regards
> jb
> 
>>
>> 2016-06-27 0:57 GMT-03:00 Jesse DuBord <jesse.dubord at gmail.com>:
>> Hey all, wanted to get community feedback on this. It looks like JB
>> has done it again with a fantastic fix for this bug
>> (https://bugs.kde.org/show_bug.cgi?id=360882). In non-KDE desktops, it
>> used to be that there were icons and functions missing (because of no
>> icons) in the Open and Add clip dialog boxes. Now that's (mostly)
>> fixed, and everything works great when you have the Breeze theme and
>> Breeze style used on non-KDE desktop environments.
>>
>> That said, I was wondering what everyone would think about having the
>> force option enabled by default? The reason I'm proposing this is
>> simple: it would, for the first time, truly unify the appearance of
>> Kdenlive across the GNU/Linux world... which gives a HUGE benefit to
>> product & brand recognition. People would be able to identify Kdenlive
>> as it is out-of-the-box.
>>
>> What do you all think?
>>
> 
> _______________________________________________
> kdenlive mailing list
> kdenlive at kde.org
> https://mail.kde.org/mailman/listinfo/kdenlive