[kdenlive] Review Request 125707: fix: Timeline incorrectly checks track index bounds crash

The DiveO thediveo at gmx.eu
Mon Oct 19 16:46:12 UTC 2015

This is an automatically generated e-mail. To reply, visit:

Review request for Kdenlive and Vincent Pinon.

Repository: kdenlive


Class Timeline incorrectly checks the bounds for track indices: the upper bound is checked against greater than track.count(), where in fact the indices run from 0 to count-1.

However, this masks the underlying problem with converted Kdenlive projects: when adding new tracks, the index gets out of bounds, so this needs to be fixed too. This patch just fixes the crash in itself but not the underlying problem of handing in an out-of-bounds index to these functions to be fixed.


  src/timeline/timeline.cpp fb5bf90 
  CMakeLists.txt a8f712f 

Diff: https://git.reviewboard.kde.org/r/125707/diff/


Tested against recent Kdenlive branch Applications/15.08, on Kubuntu 15.04 64bit system. Tested with a converted 15.04 Kdenlive project that exhibits this bug when trying to add new tracks to the timeline.


The DiveO

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20151019/2907cfd2/attachment.html>

More information about the kdenlive mailing list