[kdenlive] Review Request 125548: Configuration dialog UI improvement: show action texts assigned to jog buttons without "&"; easier to read; sorts according to user expectations

[Vincent Pinon]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125548/#review86687
-----------------------------------------------------------

Ship it!


This doesn't change translations, and can be viewed as a bugfix, so go to Applications/15.08

- Vincent Pinon


On oct. 7, 2015, 3:34 après-midi, The DiveO wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125548/
> -----------------------------------------------------------
> 
> (Updated oct. 7, 2015, 3:34 après-midi)
> 
> 
> Review request for Kdenlive.
> 
> 
> Repository: kdenlive
> 
> 
> Description
> -------
> 
> This proposed patch improves the configuration dialog UI for the Jog/Shuttle tab: the texts for actions that can be assigned to buttons of a jog/shuttle device previously contained "&". These ampersands cause action texts to be sorted in an unintuitive way that makes finding the correction action hard. This patch removes all ampersands from the action descriptive texts, so that the resulting action list is sorted according to user expectations. In particular, leading ampersands don't cause action names to get sorted into two sets: one going from &A-&Z and another one going from A-Z. With this patch, there is only a single sorted list A-Z without any distracting ampersands.
> 
> On a sidenote: Kdenlive up to 0.9.10 already removed the ampersands, only later they got in again during transition to KF5.
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.cpp e147e93 
> 
> Diff: https://git.reviewboard.kde.org/r/125548/diff/
> 
> 
> Testing
> -------
> 
> Yes; on Kdenlive Applications/15.08 with a ShuttlePRO v2 jog/shuttle device. German locale set. Action descriptive texts now appear without interspersed ampersands (&). Actions still correctly trigger and button-to-action assignments can successfully be changed and work correctly.
> 
> 
> Thanks,
> 
> The DiveO
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20151012/cbc36ff4/attachment.html>