[kdenlive] Review Request 125548: Configuration dialog UI improvement: show action texts assigned to jog buttons without "&"; easier to read; sorts according to user expectations

The DiveO thediveo at gmx.eu
Wed Oct 7 15:34:31 UTC 2015

This is an automatically generated e-mail. To reply, visit:

Review request for Kdenlive.

Repository: kdenlive


This proposed patch improves the configuration dialog UI for the Jog/Shuttle tab: the texts for actions that can be assigned to buttons of a jog/shuttle device previously contained "&". These ampersands cause action texts to be sorted in an unintuitive way that makes finding the correction action hard. This patch removes all ampersands from the action descriptive texts, so that the resulting action list is sorted according to user expectations. In particular, leading ampersands don't cause action names to get sorted into two sets: one going from &A-&Z and another one going from A-Z. With this patch, there is only a single sorted list A-Z without any distracting ampersands.

On a sidenote: Kdenlive up to 0.9.10 already removed the ampersands, only later they got in again during transition to KF5.


  src/mainwindow.cpp e147e93 

Diff: https://git.reviewboard.kde.org/r/125548/diff/


Yes; on Kdenlive Applications/15.08 with a ShuttlePRO v2 jog/shuttle device. German locale set. Action descriptive texts now appear without interspersed ampersands (&). Actions still correctly trigger and button-to-action assignments can successfully be changed and work correctly.


The DiveO

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20151007/9a0c70c9/attachment.html>

More information about the kdenlive mailing list