[kdenlive] Review Request 123628: port places file path to new user-places.xbel (kdelibs)

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Mon May 4 14:53:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123628/#review79846
-----------------------------------------------------------



src/doc/kdenlivedoc.cpp (line 1659)
<https://git.reviewboard.kde.org/r/123628/#comment54708>

    Create the manager with KBookmarkManager::managerForExternalFile instead, to get change detection even when user-places.xbel was changed by a non-KDE application.
    
    http://api.kde.org/frameworks-api/frameworks5-apidocs/kbookmarks/html/classKBookmarkManager.html#a6bb90fc4f0c1ea1c06d0176b3cb64651


- Emmanuel Pescosta


On May 4, 2015, 3:38 p.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123628/
> -----------------------------------------------------------
> 
> (Updated May 4, 2015, 3:38 p.m.)
> 
> 
> Review request for Kdenlive.
> 
> 
> Bugs: 347160
>     http://bugs.kde.org/show_bug.cgi?id=347160
> 
> 
> Repository: kdenlive
> 
> 
> Description
> -------
> 
> this commit is so distributions have something to cherrypick in case they are still shipping the kdelibs4 version of kdenlive...
> functionally the same change as https://git.reviewboard.kde.org/r/123627/ but for the v0.9.x branch.
> 
> the legacy bookmarks.xml file is not supported anymore and will stop
> syncing with the user-places.xbel starting with the upcoming kio and
> kdelibs releases.
> 
> CCBUG: 347160
> 
> 
> Diffs
> -----
> 
>   src/doc/kdenlivedoc.cpp c2f150cd1a490b2858cdd0c87d853f938f2abe46 
> 
> Diff: https://git.reviewboard.kde.org/r/123628/diff/
> 
> 
> Testing
> -------
> 
> builds. no additional testing done
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20150504/d52adf74/attachment.html>


More information about the kdenlive mailing list