[Kdenlive-devel] [PATCH 10/14] definitions.h: initialize MltVideoProfile

[Mikko Rapeli]

Found by Coverity:

CID 709303: Uninitialized scalar variable (UNINIT)
Declaring variable "profile".
2400        MltVideoProfile profile;
At conditional (1): "this->m_activeDocument" taking the false branch.
2401        if (m_activeDocument) profile = m_activeDocument->mltProfile();
Using uninitialized value "profile.colorspace" when calling "MltVideoProfile::MltVideoProfile(MltVideoProfile const &)". [hide details]
Using uninitialized value "profile.display_aspect_den" when calling "MltVideoProfile::MltVideoProfile(MltVideoProfile const &)". [show details]
Using uninitialized value "profile.display_aspect_num" when calling "MltVideoProfile::MltVideoProfile(MltVideoProfile const &)". [show details]
Using uninitialized value "profile.frame_rate_den" when calling "MltVideoProfile::MltVideoProfile(MltVideoProfile const &)". [show details]
Using uninitialized value "profile.frame_rate_num" when calling "MltVideoProfile::MltVideoProfile(MltVideoProfile const &)". [show details]
Using uninitialized value "profile.height" when calling "MltVideoProfile::MltVideoProfile(MltVideoProfile const &)". [show details]
Using uninitialized value "profile.progressive" when calling "MltVideoProfile::MltVideoProfile(MltVideoProfile const &)". [show details]
Using uninitialized value "profile.sample_aspect_den" when calling "MltVideoProfile::MltVideoProfile(MltVideoProfile const &)". [show details]
Using uninitialized value "profile.sample_aspect_num" when calling "MltVideoProfile::MltVideoProfile(MltVideoProfile const &)". [show details]
Using uninitialized value "profile.width" when calling "MltVideoProfile::MltVideoProfile(MltVideoProfile const &)". [show details]

CID 709304: Uninitialized scalar variable (UNINIT)
Declaring variable "result".
242    MltVideoProfile result;
...
---
 src/definitions.h |   14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/src/definitions.h b/src/definitions.h
index fa22620..1e03945 100644
--- a/src/definitions.h
+++ b/src/definitions.h
@@ -108,7 +108,8 @@ struct TransitionInfo {
     bool forceTrack;
 };
 
-struct MltVideoProfile {
+class MltVideoProfile {
+public:
     QString path;
     QString description;
     int frame_rate_num;
@@ -121,6 +122,17 @@ struct MltVideoProfile {
     int display_aspect_num;
     int display_aspect_den;
     int colorspace;
+    MltVideoProfile() :
+        frame_rate_num(0),
+        frame_rate_den(0),
+        width(0),
+        height(0),
+        progressive(0),
+        sample_aspect_num(0),
+        sample_aspect_den(0),
+        display_aspect_num(0),
+        display_aspect_den(0),
+        colorspace(0) {};
     bool operator==(const MltVideoProfile& point) const
     {
         if (!description.isEmpty() && point.description  == description) return true;
-- 
1.7.10.4