[Kdenlive-devel] [PATCH 09/14] kis_curve_widget_p.h: initialize private data

[Mikko Rapeli]

Found by Coverity:

 41    /* Dragging variables */
CID 709309: Uninitialized scalar field (UNINIT_CTOR)
...
CID 709309: Uninitialized pointer field (UNINIT_CTOR)
Class member declaration for ""m_pixmapCache"".
 61    QPixmap *m_pixmapCache;
 62
 63    /* In/Out controls */
Class member declaration for ""m_intIn"".
 64    QSpinBox *m_intIn;
Class member declaration for ""m_intOut"".
 65
...
131KisCurveWidget::Private::Private(KisCurveWidget *parent)
132{
133    m_curveWidget = parent;
Non-static class member ""m_draggedAwayPointIndex"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_grabOffsetX"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_grabOffsetY"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_grabOriginalX"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_grabOriginalY"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_grab_point_index"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_guideVisible"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_inOutMax"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_inOutMin"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_maxPoints"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_pixmapDirty"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_readOnlyMode"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_splineDirty"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_state"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_intIn"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_intOut"" is not initialized in this constructor nor in any functions that it calls.
Non-static class member ""m_pixmapCache"" is not initialized in this constructor nor in any functions that it calls.
134}
---
 src/kis_curve_widget_p.h |   17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/src/kis_curve_widget_p.h b/src/kis_curve_widget_p.h
index e3895f7..035742d 100644
--- a/src/kis_curve_widget_p.h
+++ b/src/kis_curve_widget_p.h
@@ -131,6 +131,23 @@ public:
 KisCurveWidget::Private::Private(KisCurveWidget *parent)
 {
     m_curveWidget = parent;
+    m_grab_point_index = 0;
+    m_grabOffsetX = 0;
+    m_grabOffsetY = 0;
+    m_grabOriginalX = 0;
+    m_grabOriginalY = 0;
+    m_draggedAwayPointIndex = 0;
+    m_readOnlyMode = 0;
+    m_guideVisible = 0;
+    m_splineDirty = 0;
+    m_pixmapDirty = 0;
+    m_pixmapCache = NULL;
+    m_intIn = NULL;
+    m_intOut = NULL;
+    m_inOutMin = 0;
+    m_inOutMax = 0;
+    m_state = ST_NORMAL;
+    m_maxPoints = 0;
 }
 
 KisCurveWidget::Private::~Private()
-- 
1.7.10.4