[Kdenlive-devel] setting mlt property from qstring

[Till Theato]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/31/2010 09:56 PM, Dan Dennedy wrote:
> When working on my latest change, I noticed the Kdenlive code was
> often using qstrdup with QString::toUtf8().data(). The qstrdup is not
> necessary because MLT already does a strdup with whatever you provide
> and then auto-releases it. I did not clean all of these up because I
> wanted to keep the change concise.

Hi,
in my last two commits (4935 & 4938) I removed almost all qstrdup calls.
I hope I did not break anything.

> 
> Also, I noticed places where it was not taking advantage of the
> inheritance in the mlt++ binding. For example, a Filter is a Service,
> which is a Properties. So, there is no need to manually fetch a
> filter's service pointer via method.

Maybe I will have a look at it, but we could also just do it when
working on related code.
Is there any disadvantage besides more code?

> 
> I realize there may be quite a bit of cruft, but I just want to give
> some feedback on what I saw in case it helps.
> 

Thanks for your hints.
till

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkyfws0ACgkQzwEyz7QP6nTLhwCfWIoZVOzHvKmTsAGddzkntZVC
XYcAnRQxJyflXpA+w48bOiIA3aYVaKOH
=1WrA
-----END PGP SIGNATURE-----