[Kdenlive-devel] [git pull] three new branches

Ray Lehtiniemi rayl at mail.com
Sun Mar 29 01:08:09 UTC 2009


hi jb, marco

please consider these three new branches. They are relative to svn revision 
3186.


--------------------------------------------------------------------
  git://github.com/rayl/kdenlive.git review-7

As discussed, this is the patch series based on the ideas in review-5.
it is primarily just an exercise in reformatting, plus some explicit
base initializer calls.  (i'm working on an extended version of this which
explicitly initializes all member variables, but it won't be ready for a 
while)

Ray Lehtiniemi (4):
      Reformat initializers.
      Sort initializers in declaration order
      Remove some more unnecessary empty variable initializations
      Ensure that all base constructors are explicitly called.

 renderer/renderjob.cpp         |    7 ++++++-
 src/abstractclipitem.cpp       |   10 +++++++++-
 src/abstractgroupitem.cpp      |    6 +++++-
 src/addclipcommand.cpp         |    8 +++++++-
 src/addeffectcommand.cpp       |    9 ++++++++-
 src/addfoldercommand.cpp       |    8 +++++++-
 src/addmarkercommand.cpp       |   10 +++++++++-
 src/addtimelineclipcommand.cpp |   11 ++++++++++-
 src/addtrackcommand.cpp        |    9 ++++++++-
 src/addtransitioncommand.cpp   |   10 +++++++++-
 src/changecliptypecommand.cpp  |   12 +++++++++++-
 src/changespeedcommand.cpp     |   10 +++++++++-
 src/changetrackcommand.cpp     |    9 ++++++++-
 src/clipdurationdialog.cpp     |    6 +++++-
 src/clipitem.cpp               |   25 ++++++++++++++++++++++++-
 src/clipmanager.cpp            |    8 +++++++-
 src/clipproperties.cpp         |    9 ++++++++-
 src/complexparameter.cpp       |    3 ++-
 src/customruler.cpp            |    7 ++++++-
 src/customtrackscene.cpp       |    5 ++++-
 src/customtrackview.cpp        |   29 ++++++++++++++++++++++++++++-
 src/docclipbase.cpp            |   18 ++++++++++++++++--
 src/dvdwizard.cpp              |    7 ++++++-
 src/dvdwizardmenu.cpp          |    4 +++-
 src/dvdwizardvob.cpp           |    4 +++-
 src/editclipcommand.cpp        |    9 ++++++++-
 src/editeffectcommand.cpp      |    9 ++++++++-
 src/editfoldercommand.cpp      |    9 ++++++++-
 src/editguidecommand.cpp       |   10 +++++++++-
 src/editkeyframecommand.cpp    |   11 ++++++++++-
 src/edittransitioncommand.cpp  |    8 +++++++-
 src/effectslist.cpp            |    5 +++--
 src/effectslistview.cpp        |    3 ++-
 src/effectslistwidget.cpp      |    4 +++-
 src/effectstackedit.cpp        |    6 +++++-
 src/effectstackview.cpp        |    3 ++-
 src/gentime.cpp                |    9 ++++++---
 src/geometryval.cpp            |    9 ++++++++-
 src/graphicsscenerectmove.cpp  |    7 ++++++-
 src/groupclipscommand.cpp      |    9 ++++++++-
 src/guide.cpp                  |    7 ++++++-
 src/headertrack.cpp            |    5 ++++-
 src/initeffects.cpp            |    8 ++++++--
 src/insertspacecommand.cpp     |    9 ++++++++-
 src/jogshuttle.cpp             |    4 +++-
 src/kdenlivedoc.cpp            |   17 ++++++++++++++++-
 src/kdenlivesettingsdialog.cpp |    4 +++-
 src/keyframehelper.cpp         |    6 +++++-
 src/locktrackcommand.cpp       |    8 +++++++-
 src/mainwindow.cpp             |   12 ++++++++----
 src/managecapturesdialog.cpp   |    4 +++-
 src/markerdialog.cpp           |    9 ++++++++-
 src/monitor.cpp                |   19 ++++++++++++++++---
 src/monitormanager.cpp         |    3 ++-
 src/moveclipcommand.cpp        |    8 +++++++-
 src/moveeffectcommand.cpp      |   10 +++++++++-
 src/movegroupcommand.cpp       |   10 +++++++++-
 src/movetransitioncommand.cpp  |    8 +++++++-
 src/parameterplotter.cpp       |    4 +++-
 src/profilesdialog.cpp         |    6 +++++-
 src/projectitem.cpp            |   13 ++++++++++---
 src/projectlist.cpp            |   14 +++++++++++++-
 src/projectlistview.cpp        |    4 +++-
 src/projectsettings.cpp        |    5 ++++-
 src/razorclipcommand.cpp       |    8 +++++++-
 src/recmonitor.cpp             |    8 +++++++-
 src/regiongrabber.cpp          |   27 +++++++++++++++++++--------
 src/renderer.cpp               |   16 +++++++++++++++-
 src/renderwidget.cpp           |    5 ++++-
 src/resizeclipcommand.cpp      |    8 +++++++-
 src/slideshowclip.cpp          |    5 ++++-
 src/smallruler.cpp             |    5 ++++-
 src/spacerdialog.cpp           |    5 ++++-
 src/splitaudiocommand.cpp      |    8 +++++++-
 src/statusbarmessagelabel.cpp  |   17 +++++++++--------
 src/timecode.cpp               |    8 +++++---
 src/titledocument.cpp          |    3 ++-
 src/titlewidget.cpp            |   10 +++++++++-
 src/trackview.cpp              |    6 +++++-
 src/transition.cpp             |    6 +++++-
 src/transitionsettings.cpp     |    6 +++++-
 src/wizard.cpp                 |    4 +++-
 thumbnailer/westleypreview.cpp |    6 +++++-
 83 files changed, 602 insertions(+), 111 deletions(-)



--------------------------------------------------------------------
  git://github.com/rayl/kdenlive.git review-8

This one is just two trivial patches.

Ray Lehtiniemi (2):
      Add braces and update indentation to clarify ambiguous if/else
      Missing include guards in a header file

 src/parameterplotter.h |    5 +++++
 src/titledocument.cpp  |   46 ++++++++++++++++++++++------------------------
 2 files changed, 27 insertions(+), 24 deletions(-)





--------------------------------------------------------------------
  git://github.com/rayl/kdenlive.git review-9

how would you guys feel about a patchset like this?  it makes life a _lot_ 
better for vim users...

Ray Lehtiniemi (1):
      Move opening brace of function body to first column.

 src/effectslist.cpp |   39 ++++++++++++++++++++++++++-------------
 1 files changed, 26 insertions(+), 13 deletions(-)




thanks
ray





More information about the Kdenlive mailing list