[Kdenlive-devel] Patch included: Re: Handling display aspect ratio for custom resolutions?

[Mads Bondo Dydensborg]

torsdag 23 Oktober 2008 skrev Mads Bondo Dydensborg:

> However, the custom profiles entry dialog in kdenlive limits the dar 
settings 
> to 1-99 ... so, the closest I have gotten, is 98 / 71. But this is not 
> correct, and when e.g. extracting a frame, the resulting frame size will be 
> 840x604, as the dar is multiplied on the heigt to get the width.
> 
> Is there a reason to this limit in the dialog, or can it be removed? Or, is 
> there a better way to handle custom resolutions from e.g. screen grabs?
> 
> 
> P.S. I think it is within my capabilities to actually remove the limit from 
> the gui, if I get a "OK" to go.

The patch below fixes this issue, as well as allowing users to see that the 
framerate num for NTSC is 30000! Without this patch, all ntsc framerate nums 
are clipped to 10000 in the GUI profile editor, while they actually are 30000 
in the profile files, and when selecting them as project profiles. 

The patch is more or less trivial, and I have confirmed that it works when 
extracting a still. 10000 was chosen to match the max values for the 
resolution and I think mlt pretty much don't care about these numbers as long 
as they are positive and < MAX_INT, so... ok to commit?

Index: src/widgets/profiledialog_ui.ui
===================================================================
--- src/widgets/profiledialog_ui.ui     (revision 2542)
+++ src/widgets/profiledialog_ui.ui     (working copy)
@@ -96,7 +96,7 @@
       <item row="2" column="1" >
        <widget class="KIntSpinBox" name="frame_num" >
         <property name="maximum" >
-         <number>10000</number>
+         <number>30000</number>
         </property>
        </widget>
       </item>
@@ -154,7 +154,11 @@
        </widget>
       </item>
       <item row="4" column="1" >
-       <widget class="KIntSpinBox" name="display_num" />
+       <widget class="KIntSpinBox" name="display_num" >
+        <property name="maximum" >
+         <number>10000</number>
+        </property>
+       </widget>
       </item>
       <item row="4" column="2" >
        <widget class="QLabel" name="label_8" >
@@ -170,7 +174,11 @@
        </widget>
       </item>
       <item row="4" column="3" >
-       <widget class="KIntSpinBox" name="display_den" />
+       <widget class="KIntSpinBox" name="display_den" >
+        <property name="maximum" >
+         <number>10000</number>
+        </property>
+       </widget>
       </item>
       <item row="5" column="0" colspan="4" >
        <widget class="QCheckBox" name="progressive" >


-- 
Mads Bondo Dydensborg   mads at dydensborg.dk   http://www.madsdydensborg.dk/

Today, the record companies are saying MP3s are the biggest evil. Tomorrow 
they're going to say they're the greatest thing when they figure
them out.
                               - Gene Kan, Gnutella developer