[Kdenlive-devel] A little patch to prevent crash on exit (splash not initialized)

Thomas Orgis thomas-forum at orgis.org
Mon Dec 31 11:55:08 UTC 2007


Hi, I'm strugglign to get some work done with kdenlive and found
out that I can at least fix one of my problems:
Everytime I close the app, it gets a crash.

Reason: if(splash) delete splash;
splash not intialized to NULL if _not_ splash has been shown.

Please consider including this patch in SVN (OK, the second changed
line has no direct effect on the crash but 0L for a pointer just
looked wrong):

Index: kdenlive/kdenlive.cpp
===================================================================
--- kdenlive/kdenlive.cpp	(Revision 1781)
+++ kdenlive/kdenlive.cpp	(Arbeitskopie)
@@ -135,6 +135,7 @@
     KdenliveApp::KdenliveApp(bool newDoc, QWidget *parent,
 	const char *name):KDockMainWindow(parent, name), m_monitorManager(this),
     m_workspaceMonitor(NULL), m_clipMonitor(NULL), m_captureMonitor(NULL), m_exportWidget(NULL), m_renderManager(NULL), m_doc(NULL), m_selectedFile(NULL), m_copiedClip(NULL), m_projectList(NULL), m_effectStackDialog(NULL), m_effectListDialog(NULL), m_projectFormat("dv_pal"), m_timelinePopupMenu(NULL), m_rulerPopupMenu(NULL), m_exportDvd(NULL), m_transitionPanel(NULL), m_resizeFunction(NULL), m_moveFunction(NULL), m_rollFunction(NULL), m_markerFunction(NULL),m_newLumaDialog(NULL), m_externalMonitor(0), m_debugDialog(NULL) {
+	splash = NULL; // Initialize this!
 
 	parseProfiles();
 	config = kapp->config();
@@ -400,7 +401,7 @@
     void KdenliveApp::slotSplashTimeout()
     {
         delete splash;
-        splash = 0L;
+        splash = NULL;
     }

-- 
Thomas Orgis - Source Mage GNU/Linux Developer (http://www.sourcemage.org)
OrgisNetzOrganisation ---)=- http://orgis.org
GPG public key D446D524: http://thomas.orgis.org/public_key
Fingerprint: 7236 3885 A742 B736 E0C8 9721 9B4C 52BC D446 D524
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20071231/cd17fdab/attachment.sig>


More information about the Kdenlive mailing list