D18354: Use QPointer for notification

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> notification.cpp:86
>  {
>      if (!update) {
>          m_notification = new KNotification(QStringLiteral("notification"), KNotification::CloseOnTimeout, this);

Can't this be simplified to drop the `update` argument and just check for `m_notification`?

This method is only used in the constructor where `m_notification` is `null` anyway, and in `update` where you check for `m_notification`

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D18354

To: nicolasfella, #kde_connect, broulik
Cc: kdeconnect, vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190118/4da49b4a/attachment-0001.html>