D18354: Use QPointer for notification

Nicolas Fella noreply at phabricator.kde.org
Fri Jan 18 10:13:10 GMT 2019


nicolasfella created this revision.
nicolasfella added reviewers: KDE Connect, broulik.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The Knotification object is destroyed when the notification disappears. When we try to access it bad things happen. Use a QPointer and check if it's still valid before
  using it
  
  BUG: 400010

TEST PLAN
  Spawned some notifications

REPOSITORY
  R224 KDE Connect

BRANCH
  noti

REVISION DETAIL
  https://phabricator.kde.org/D18354

AFFECTED FILES
  plugins/notifications/notification.cpp
  plugins/notifications/notification.h

To: nicolasfella, #kde_connect, broulik
Cc: kdeconnect, vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190118/f6733813/attachment.html>


More information about the KDEConnect mailing list