D18181: Allow disabling persistent notification in Android 8.0 and up

[Albert Vaca Cintora]

albertvaka accepted this revision.
albertvaka added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> strings.xml:317
>      <string name="setting_persistent_notification">Show persistent notification</string>
> -    <string name="setting_persistent_notification_oreo_description">Required by Android since Android 8.0</string>
> -    <string name="setting_persistent_notification_pie_description">Since Android 9.0, this notification can only be minimized by long tapping on it</string>
> +    <string name="setting_persistent_notification_oreo">Persistent Notification</string>
> +    <string name="setting_persistent_notification_description">Tap to enable/disable in Notification settings</string>

Use lowercase "n" in notification.

> SettingsFragment.java:35
>  
> -        mainActivity = (MainActivity)getActivity();
> +        mainActivity = (MainActivity) getActivity();
>          Context context = getPreferenceManager().getContext();

Try not to include unrelated changes in patches, like this added space.

REPOSITORY
  R225 KDE Connect - Android application

BRANCH
  arcpatch-D18181

REVISION DETAIL
  https://phabricator.kde.org/D18181

To: brute4s99, #kde_connect, albertvaka
Cc: albertvaka, eduisters, nicolasfella, kdeconnect, #kde_connect, vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190116/28e5dbf8/attachment.html>