<table><tr><td style="">albertvaka accepted this revision.<br />albertvaka added inline comments.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18181">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18181#inline-101133">View Inline</a><span style="color: #4b4d51; font-weight: bold;">strings.xml:317</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #00702a"><string</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"setting_persistent_notification"</span><span style="color: #00702a">></span>Show persistent notification<span style="color: #00702a"></string></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #00702a"><string</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"setting_persistent_notification_oreo<span class="bright">_description"</span></span><span class="bright"></span><span style="color: #00702a"><span class="bright">></span></span><span class="bright">Required by Android since Android 8.0</span><span style="color: #00702a"></string></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #00702a"><string</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"setting_persistent_notification_<span class="bright">pie_</span>description"</span><span style="color: #00702a">><span class="bright"></span></span><span class="bright">Since Android 9.0, this n</span>otification <span class="bright">can only be minimized by long tapping on it</span><span style="color: #00702a"></string></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #00702a"><string</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"setting_persistent_notification_oreo<span class="bright">"</span></span><span class="bright"></span><span style="color: #00702a"><span class="bright">></span></span><span class="bright">Persistent Notification</span><span style="color: #00702a"></string></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #00702a"><string</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"setting_persistent_notification_description"</span><span style="color: #00702a">><span class="bright"></span></span><span class="bright">Tap to enable/disable in N</span>otification <span class="bright">settings</span><span style="color: #00702a"></string></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use lowercase "n" in notification.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18181#inline-101135">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SettingsFragment.java:35</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">mainActivity</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">(</span><span class="n">MainActivity</span><span style="color: #aa2211">)</span><span class="n">getActivity</span><span style="color: #aa2211">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">mainActivity</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">(</span><span class="n">MainActivity</span><span style="color: #aa2211">)<span class="bright"></span></span><span class="bright"> </span><span class="n">getActivity</span><span style="color: #aa2211">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">Context</span> <span class="n">context</span> <span style="color: #aa2211">=</span> <span class="n">getPreferenceManager</span><span style="color: #aa2211">().</span><span style="color: #354bb3">getContext</span><span style="color: #aa2211">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Try not to include unrelated changes in patches, like this added space.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>BRANCH</strong><div><div>arcpatch-D18181</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18181">https://phabricator.kde.org/D18181</a></div></div><br /><div><strong>To: </strong>brute4s99, KDE Connect, albertvaka<br /><strong>Cc: </strong>albertvaka, eduisters, nicolasfella, kdeconnect, KDE Connect, vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara, apol<br /></div>