D15813: Respect users prefered text editor for shared text

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Sep 28 15:13:26 BST 2018


apol requested changes to this revision.
apol added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> shareplugin.cpp:120
>              connect(proc, SIGNAL(finished(int)), proc, SLOT(deleteLater()));
> -            proc->start(QStringLiteral("kate"), QStringList(QStringLiteral("--stdin")));
> +            proc->start(defaultApp.section('.', 2,2), QStringList(QStringLiteral("--stdin")));
>              proc->write(text.toUtf8());

Ugh yeah, no. Extract the executable name from the server, not from the id. They may be different!

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D15813

To: nicolasfella, #kde_connect, broulik, apol
Cc: kdeconnect, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180928/75b0035b/attachment.html>


More information about the KDEConnect mailing list