D15788: [cli] Allow sharing files and URLs together

Nicolas Fella noreply at phabricator.kde.org
Thu Sep 27 17:22:49 BST 2018


nicolasfella added inline comments.

INLINE COMMENTS

> apol wrote in kdeconnect-cli.cpp:156
> while at it, pass a third argument being `QUrl::AssumeLocalFile`. Otherwise sometimes it decides you want to share `http://myfile.odt`.

But that would interpret google.com as a file, which is not what I would expect. If myfile.odt exists and is interpreted as http://myfile.odt that would be a bug in Qt. If myfile.odt doesn't exist it doesn't make sense sharing it, does it?

REPOSITORY
  R224 KDE Connect

BRANCH
  sharemore

REVISION DETAIL
  https://phabricator.kde.org/D15788

To: nicolasfella, #kde_connect, apol
Cc: apol, kdeconnect, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180927/1156f8b5/attachment.html>


More information about the KDEConnect mailing list