D15788: [cli] Allow sharing files and URLs together

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Sep 27 02:18:52 BST 2018


apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kdeconnect-cli.cpp:156
> +            for (const QString& input : parser.positionalArguments()) {
> +                QUrl url = QUrl::fromUserInput(input, QDir::currentPath());
> +                urls.append(url);

while at it, pass a third argument being `QUrl::AssumeLocalFile`. Otherwise sometimes it decides you want to share `http://myfile.odt`.

REPOSITORY
  R224 KDE Connect

BRANCH
  sharemore

REVISION DETAIL
  https://phabricator.kde.org/D15788

To: nicolasfella, #kde_connect, apol
Cc: apol, kdeconnect, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180927/563605c6/attachment-0001.html>


More information about the KDEConnect mailing list