D15608: [Desktop] Prevent SMS app from requesting entire contents of every conversation

[Simon Redman]

sredman created this revision.
Herald added a project: KDE Connect.
Herald added a subscriber: kdeconnect.
sredman requested review of this revision.

REVISION SUMMARY
  Previously, when the conversations list was being populated, it made a request for the first message in every conversation. This would be fine if the conversationdbusinterface pulled from local cache. However, this actually triggers a request to the phone for *every* conversation.
  
  This should be handled differently in conversationdbusinterface's requestConversation as well, but that's a project for a later day (TODO comments added)

TEST PLAN
  - Launch SMS app
  - Verify conversations list appears
  - Verify lack of massive stream of debug output indicating lots of messages for the wrong conversation are being received
  - Verify that opening a particular conversation shows the messages after a short delay while the backend fetches the content from the phone

REPOSITORY
  R224 KDE Connect

BRANCH
  convo-preview-update

REVISION DETAIL
  https://phabricator.kde.org/D15608

AFFECTED FILES
  plugins/sms/conversationsdbusinterface.cpp
  plugins/sms/conversationsdbusinterface.h
  smsapp/conversationlistmodel.cpp
  smsapp/conversationlistmodel.h

To: sredman
Cc: kdeconnect, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180919/26a251d5/attachment.html>