D15544: [Android] Cleanup SMS plugin and document deprecated SMS-relevant Telephony packet types

[Nicolas Fella]

nicolasfella accepted this revision.
nicolasfella added a comment.
This revision is now accepted and ready to land.


  Some nitpicks, otherwise looks good

INLINE COMMENTS

> SMSPlugin.java:96
>       */
> -    public final static String PACKET_TYPE_TELEPHONY_REQUEST_CONVERSATIONS = "kdeconnect.telephony.request_conversations";
> +    public final static String PACKET_TYPE_SMS_REQUEST_CONVERSATIONS = "kdeconnect.sms.request_conversations";
>  

can be private

> SMSPlugin.java:105
>       */
> -    public final static String PACKET_TYPE_TELEPHONY_REQUEST_CONVERSATION = "kdeconnect.telephony.request_conversation";
> +    public final static String PACKET_TYPE_SMS_REQUEST_CONVERSATION = "kdeconnect.sms.request_conversation";
>  

Can be private

> SMSPlugin.java:274
>  
>      protected boolean handleRequestConversation(NetworkPacket packet) {
>          SMSHelper.ThreadID threadID = new SMSHelper.ThreadID(packet.getInt("threadID"));

Can be private

REPOSITORY
  R225 KDE Connect - Android application

BRANCH
  sms-packet-update

REVISION DETAIL
  https://phabricator.kde.org/D15544

To: sredman, #kde_connect, nicolasfella
Cc: nicolasfella, kdeconnect, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180916/2e516886/attachment.html>