<table><tr><td style="">nicolasfella accepted this revision.<br />nicolasfella added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15544">View Revision</a></tr></table><br /><div><div><p>Some nitpicks, otherwise looks good</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15544#inline-83751">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SMSPlugin.java:96</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">     */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">public</span> <span style="color: #aa4000">final</span> <span style="color: #aa4000">static</span> <span class="n">String</span> <span class="n">PACKET_TYPE_<span class="bright">TELEPHONY</span>_REQUEST_CONVERSATIONS</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"kdeconnect.<span class="bright">telephony</span>.request_conversations"</span><span style="color: #aa2211">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">public</span> <span style="color: #aa4000">final</span> <span style="color: #aa4000">static</span> <span class="n">String</span> <span class="n">PACKET_TYPE_<span class="bright">SMS</span>_REQUEST_CONVERSATIONS</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"kdeconnect.<span class="bright">sms</span>.request_conversations"</span><span style="color: #aa2211">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">can be private</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15544#inline-83750">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SMSPlugin.java:105</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">     */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">public</span> <span style="color: #aa4000">final</span> <span style="color: #aa4000">static</span> <span class="n">String</span> <span class="n">PACKET_TYPE_<span class="bright">TELEPHONY</span>_REQUEST_CONVERSATION</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"kdeconnect.<span class="bright">telephony</span>.request_conversation"</span><span style="color: #aa2211">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">public</span> <span style="color: #aa4000">final</span> <span style="color: #aa4000">static</span> <span class="n">String</span> <span class="n">PACKET_TYPE_<span class="bright">SMS</span>_REQUEST_CONVERSATION</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"kdeconnect.<span class="bright">sms</span>.request_conversation"</span><span style="color: #aa2211">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can be private</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15544#inline-83753">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SMSPlugin.java:274</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">protected</span> <span style="color: #aa4000">boolean</span> <span style="color: #004012">handleRequestConversation</span><span style="color: #aa2211">(</span><span class="n">NetworkPacket</span> <span class="n">packet</span><span style="color: #aa2211">)</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">SMSHelper</span><span style="color: #aa2211">.</span><span style="color: #354bb3">ThreadID</span> <span class="n">threadID</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">SMSHelper</span><span style="color: #aa2211">.</span><span style="color: #354bb3">ThreadID</span><span style="color: #aa2211">(</span><span class="n">packet</span><span style="color: #aa2211">.</span><span style="color: #354bb3">getInt</span><span style="color: #aa2211">(</span><span style="color: #766510">"threadID"</span><span style="color: #aa2211">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can be private</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>BRANCH</strong><div><div>sms-packet-update</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15544">https://phabricator.kde.org/D15544</a></div></div><br /><div><strong>To: </strong>sredman, KDE Connect, nicolasfella<br /><strong>Cc: </strong>nicolasfella, kdeconnect, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol<br /></div>