D15338: WIP: Advertise over mDNS

[Teemu Rytilahti]

rytilahti added a comment.


  Thanks for the feedback Simon!
  
  In D15338#324374 <https://phabricator.kde.org/D15338#324374>, @sredman wrote:
  
  > I really like this as an idea! Even if it only works in the same places as the current UDP broadcast (and my quick testing says it should work more places) it feels way more modern and professional. Of course, we really need support on (at least one of) Android and desktop for using this to initiate a pairing.
  
  
  One of the reasons I delved into this is the fact that my phone may be sometimes in a separate network, which can thankfully be enabled fairly easily: https://www.systutorials.com/docs/linux/man/5-avahi-daemon.conf/#lbAH :-)
  
  I'll see to implement the pairing initiation inside this PR.

INLINE COMMENTS

> sredman wrote in lanlinkprovider.cpp:115-117
> Avoiding code reuse is definitely good, but maybe it would make even more sense to have a higher-level helper function, something like "get device identity", which maybe returns some custom "identity" class(/struct) and is used by both this and the createIdentityPacket method? That just feels a little nicer that "ad-hoc" using the identity packet, and is robust to the potential of that packet changing in the future.

Indeed, this was just a PoC to see how easy it would be to add support for this. A simple identity wrapper sounds like a way to go, I'll see what I can do.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D15338

To: rytilahti
Cc: sredman, kdeconnect, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180912/23e20212/attachment.html>