D16475: [SMS App] Make requestMoreMessages asynchronous, blocking, and caching
Simon Redman
noreply at phabricator.kde.org
Mon Oct 29 00:02:02 GMT 2018
sredman updated this revision to Diff 44394.
sredman added a comment.
Address comments from D15979 <https://phabricator.kde.org/D15979>
- Simplify value-getting
- Simplify condition
REPOSITORY
R224 KDE Connect
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16475?vs=44393&id=44394
BRANCH
asynchonous-message-fetch
REVISION DETAIL
https://phabricator.kde.org/D16475
AFFECTED FILES
plugins/sms/CMakeLists.txt
plugins/sms/conversationsdbusinterface.cpp
plugins/sms/conversationsdbusinterface.h
plugins/sms/requestconversationworker.cpp
plugins/sms/requestconversationworker.h
plugins/sms/smsplugin.cpp
plugins/sms/smsplugin.h
smsapp/conversationmodel.cpp
smsapp/conversationmodel.h
smsapp/qml/ConversationDisplay.qml
To: sredman, #kde_connect
Cc: apol, nicolasfella, kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181029/e40c94b0/attachment-0001.html>
More information about the KDEConnect
mailing list