<table><tr><td style="">sredman updated this revision to Diff 44394.<br />sredman added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16475">View Revision</a></tr></table><br /><div><div><p>Address comments from <a href="https://phabricator.kde.org/D15979" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D15979</a></p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Simplify value-getting</li>
<li class="remarkup-list-item">Simplify condition</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R224 KDE Connect</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D16475?vs=44393&id=44394">https://phabricator.kde.org/D16475?vs=44393&id=44394</a></div></div><br /><div><strong>BRANCH</strong><div><div>asynchonous-message-fetch</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16475">https://phabricator.kde.org/D16475</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>plugins/sms/CMakeLists.txt<br />
plugins/sms/conversationsdbusinterface.cpp<br />
plugins/sms/conversationsdbusinterface.h<br />
plugins/sms/requestconversationworker.cpp<br />
plugins/sms/requestconversationworker.h<br />
plugins/sms/smsplugin.cpp<br />
plugins/sms/smsplugin.h<br />
smsapp/conversationmodel.cpp<br />
smsapp/conversationmodel.h<br />
smsapp/qml/ConversationDisplay.qml</div></div></div><br /><div><strong>To: </strong>sredman, KDE Connect<br /><strong>Cc: </strong>apol, nicolasfella, kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara<br /></div>