D16351: Broadcast actual tcp server port used

[Simon Redman]

sredman added a comment.


  This looks like a good idea. Do you have a test case where the server ends up running on a different port?

INLINE COMMENTS

> LanLinkProvider.java:396
>              NetworkPacket identity = NetworkPacket.createIdentityPacket(context);
> -            identity.set("tcpPort", MIN_PORT);
> +            int port = (tcpServer == null || !tcpServer.isBound()) ? MIN_PORT : tcpServer.getLocalPort();
> +            identity.set("tcpPort", port);

I am not an expert in this code. Do you know in what cases tcpServer would be null or not bound? Does it make sense to even try to prepare a packet in those cases? (In other words, should these checks be outside of this method?)

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D16351

To: eduisters, #kde_connect
Cc: sredman, kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181023/542a38ac/attachment.html>