<table><tr><td style="">sredman added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16351">View Revision</a></tr></table><br /><div><div><p>This looks like a good idea. Do you have a test case where the server ends up running on a different port?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16351#inline-89281">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LanLinkProvider.java:396</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">NetworkPacket</span> <span class="n">identity</span> <span style="color: #aa2211">=</span> <span class="n">NetworkPacket</span><span style="color: #aa2211">.</span><span style="color: #354bb3">createIdentityPacket</span><span style="color: #aa2211">(</span><span class="n">context</span><span style="color: #aa2211">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">i<span class="bright">dentity</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">.</span></span><span class="bright"></span><span style="color: #354bb3"><span class="bright">set</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"tcpPort"</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">,</span></span> <span class="n">MIN_PORT</span><span style="color: #aa2211">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">i<span class="bright">nt</span></span><span class="bright"> </span><span class="n"><span class="bright">port</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">tcpServer</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">null</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">!</span></span><span class="bright"></span><span class="n"><span class="bright">tcpServer</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">.</span></span><span class="bright"></span><span style="color: #354bb3"><span class="bright">isBound</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">())</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span> <span class="n">MIN_PORT<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span class="n"><span class="bright">tcpServer</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">.</span></span><span class="bright"></span><span style="color: #354bb3"><span class="bright">getLocalPort</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">(</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">identity</span><span style="color: #aa2211">.</span><span style="color: #354bb3">set</span><span style="color: #aa2211">(</span><span style="color: #766510">"tcpPort"</span><span style="color: #aa2211">,</span> <span class="n">port</span><span style="color: #aa2211">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I am not an expert in this code. Do you know in what cases tcpServer would be null or not bound? Does it make sense to even try to prepare a packet in those cases? (In other words, should these checks be outside of this method?)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16351">https://phabricator.kde.org/D16351</a></div></div><br /><div><strong>To: </strong>eduisters, KDE Connect<br /><strong>Cc: </strong>sredman, kdeconnect, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara, apol<br /></div>