D16092: Make SmsPlugin::requestConversation synchronous and blocking

[Simon Redman]

sredman added a comment.


  In D16092 <https://phabricator.kde.org/D16092>, @apol wrote:
  
  > I would really recommend against using QEventLoop, it's a source for crashes every time.
  >  Would it maybe make sense to move this into a separate thread somehow?
  
  
  Yes, I think having ConversationDbusInterface on its own thread would be the best answer to this problem. However, I couldn't figure out a way to do this which also had  the service properly registered on dbus. I tried everything I could think of, from subclassing QThread to using QThread properly and connecting to its started signal. I was able to get the SMS plugin on a new thread (using QObject::movetothread) and responding to requests, but whenever the ConversationDbusInterface was on another thread it was not visible on dbus. I think you have more QDbus experience than I do so you might be able to get it working :)

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16092

To: sredman, #kde_connect
Cc: apol, kdeconnect, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181012/b1bf9998/attachment.html>