D16092: Make SmsPlugin::requestConversation synchronous and blocking

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> smsplugin.cpp:86
> +
> +    m_threadWaitingRequests[conversationID.toInt()] = true;
>  

Use threadID?

> sredman wrote in smsplugin.cpp:93
> Reenter the thread's event loop. loop.exec() does not return until signaled to quit

I missed this part, sorry.

I would really recommend against using QEventLoop, it's a source for crashes every time.
Would it maybe make sense to move this into a separate thread somehow?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16092

To: sredman, #kde_connect
Cc: apol, kdeconnect, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181011/98f81368/attachment.html>