D16475: [SMS App] Make requestMoreMessages asynchronous, blocking, and caching

[Nicolas Fella]

nicolasfella requested changes to this revision.
nicolasfella added a comment.
This revision now requires changes to proceed.


  I get some compile errors, apparently you need to explicitly covert int to QString
  
    /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp: In member function 'void ConversationModel::sendReplyToConversation(const QString&)':
    /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:79:51: error: invalid user-defined conversion from 'qint32' {aka 'int'} to 'const QString&' [-fpermissive]
         m_conversationsInterface->replyToConversation(m_threadId, message);
                                                       ^~~~~~~~~~
    In file included from /usr/include/qt/QtCore/qhashfunctions.h:44,
                     from /usr/include/qt/QtCore/qlist.h:47,
                     from /usr/include/qt/QtCore/qvariant.h:45,
                     from /usr/include/qt/QtCore/qabstractitemmodel.h:43,
                     from /usr/include/qt/QtGui/qstandarditemmodel.h:44,
                     from /usr/include/qt/QtGui/QStandardItemModel:1,
                     from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.h:25,
                     from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:22:
    /usr/include/qt/QtCore/qstring.h:693:31: note: candidate is: 'QString::QString(const char*)' <near match>
         inline QT_ASCII_CAST_WARN QString(const char *ch)
                                   ^~~~~~~
    /usr/include/qt/QtCore/qstring.h:693:31: note:   conversion of argument 1 would be ill-formed:
    /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:79:51: error: invalid conversion from 'qint32' {aka 'int'} to 'const char*' [-fpermissive]
         m_conversationsInterface->replyToConversation(m_threadId, message);
                                                       ^~~~~~~~~~
    /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:79:51: error: invalid conversion from 'qint32' {aka 'int'} to 'const char*' [-fpermissive]
    In file included from /usr/include/qt/QtCore/qhashfunctions.h:44,
                     from /usr/include/qt/QtCore/qlist.h:47,
                     from /usr/include/qt/QtCore/qvariant.h:45,
                     from /usr/include/qt/QtCore/qabstractitemmodel.h:43,
                     from /usr/include/qt/QtGui/qstandarditemmodel.h:44,
                     from /usr/include/qt/QtGui/QStandardItemModel:1,
                     from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.h:25,
                     from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:22:
    /usr/include/qt/QtCore/qstring.h:693:51: note:   initializing argument 1 of 'QString::QString(const char*)'
         inline QT_ASCII_CAST_WARN QString(const char *ch)
                                           ~~~~~~~~~~~~^~
    In file included from /home/nico/workspace/kdeconnect-kde/interfaces/dbusinterfaces.h:39,
                     from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.h:29,
                     from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:22:
    /home/nico/workspace/kdeconnect-kde/interfaces/conversationsinterface.h:45:32: note:   initializing argument 1 of 'QDBusPendingReply<> OrgKdeKdeconnectDeviceConversationsInterface::replyToConversation(const QString&, const QString&)'
         inline QDBusPendingReply<> replyToConversation(const QString &conversationID, const QString &message)
                                    ^~~~~~~~~~~~~~~~~~~
    /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp: In member function 'void ConversationModel::requestMoreMessages(const quint32&)':
    /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:88:51: error: invalid user-defined conversion from 'qint32' {aka 'int'} to 'const QString&' [-fpermissive]
         m_conversationsInterface->requestConversation(m_threadId, numMessages, numMessages + howMany);
                                                       ^~~~~~~~~~
    In file included from /usr/include/qt/QtCore/qhashfunctions.h:44,
                     from /usr/include/qt/QtCore/qlist.h:47,
                     from /usr/include/qt/QtCore/qvariant.h:45,
                     from /usr/include/qt/QtCore/qabstractitemmodel.h:43,
                     from /usr/include/qt/QtGui/qstandarditemmodel.h:44,
                     from /usr/include/qt/QtGui/QStandardItemModel:1,
                     from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.h:25,
                     from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:22:
    /usr/include/qt/QtCore/qstring.h:693:31: note: candidate is: 'QString::QString(const char*)' <near match>
         inline QT_ASCII_CAST_WARN QString(const char *ch)
                                   ^~~~~~~
    /usr/include/qt/QtCore/qstring.h:693:31: note:   conversion of argument 1 would be ill-formed:
    /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:88:51: error: invalid conversion from 'qint32' {aka 'int'} to 'const char*' [-fpermissive]
         m_conversationsInterface->requestConversation(m_threadId, numMessages, numMessages + howMany);
                                                       ^~~~~~~~~~
    /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:88:51: error: invalid conversion from 'qint32' {aka 'int'} to 'const char*' [-fpermissive]
    In file included from /usr/include/qt/QtCore/qhashfunctions.h:44,
                     from /usr/include/qt/QtCore/qlist.h:47,
                     from /usr/include/qt/QtCore/qvariant.h:45,
                     from /usr/include/qt/QtCore/qabstractitemmodel.h:43,
                     from /usr/include/qt/QtGui/qstandarditemmodel.h:44,
                     from /usr/include/qt/QtGui/QStandardItemModel:1,
                     from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.h:25,
                     from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:22:
    /usr/include/qt/QtCore/qstring.h:693:51: note:   initializing argument 1 of 'QString::QString(const char*)'
         inline QT_ASCII_CAST_WARN QString(const char *ch)
                                           ~~~~~~~~~~~~^~
    In file included from /home/nico/workspace/kdeconnect-kde/interfaces/dbusinterfaces.h:39,
                     from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.h:29,
                     from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:22:
    /home/nico/workspace/kdeconnect-kde/interfaces/conversationsinterface.h:58:32: note:   initializing argument 1 of 'QDBusPendingReply<> OrgKdeKdeconnectDeviceConversationsInterface::requestConversation(const QString&, int, int)'
         inline QDBusPendingReply<> requestConversation(const QString &conversationID, int start, int end)

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16475

To: sredman, #kde_connect, nicolasfella
Cc: apol, nicolasfella, kdeconnect, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181128/4865a5a7/attachment.html>