<table><tr><td style="">nicolasfella requested changes to this revision.<br />nicolasfella added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16475">View Revision</a></tr></table><br /><div><div><p>I get some compile errors, apparently you need to explicitly covert int to QString</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">/home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp: In member function 'void ConversationModel::sendReplyToConversation(const QString&)':
/home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:79:51: error: invalid user-defined conversion from 'qint32' {aka 'int'} to 'const QString&' [-fpermissive]
     m_conversationsInterface->replyToConversation(m_threadId, message);
                                                   ^~~~~~~~~~
In file included from /usr/include/qt/QtCore/qhashfunctions.h:44,
                 from /usr/include/qt/QtCore/qlist.h:47,
                 from /usr/include/qt/QtCore/qvariant.h:45,
                 from /usr/include/qt/QtCore/qabstractitemmodel.h:43,
                 from /usr/include/qt/QtGui/qstandarditemmodel.h:44,
                 from /usr/include/qt/QtGui/QStandardItemModel:1,
                 from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.h:25,
                 from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:22:
/usr/include/qt/QtCore/qstring.h:693:31: note: candidate is: 'QString::QString(const char*)' <near match>
     inline QT_ASCII_CAST_WARN QString(const char *ch)
                               ^~~~~~~
/usr/include/qt/QtCore/qstring.h:693:31: note:   conversion of argument 1 would be ill-formed:
/home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:79:51: error: invalid conversion from 'qint32' {aka 'int'} to 'const char*' [-fpermissive]
     m_conversationsInterface->replyToConversation(m_threadId, message);
                                                   ^~~~~~~~~~
/home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:79:51: error: invalid conversion from 'qint32' {aka 'int'} to 'const char*' [-fpermissive]
In file included from /usr/include/qt/QtCore/qhashfunctions.h:44,
                 from /usr/include/qt/QtCore/qlist.h:47,
                 from /usr/include/qt/QtCore/qvariant.h:45,
                 from /usr/include/qt/QtCore/qabstractitemmodel.h:43,
                 from /usr/include/qt/QtGui/qstandarditemmodel.h:44,
                 from /usr/include/qt/QtGui/QStandardItemModel:1,
                 from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.h:25,
                 from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:22:
/usr/include/qt/QtCore/qstring.h:693:51: note:   initializing argument 1 of 'QString::QString(const char*)'
     inline QT_ASCII_CAST_WARN QString(const char *ch)
                                       ~~~~~~~~~~~~^~
In file included from /home/nico/workspace/kdeconnect-kde/interfaces/dbusinterfaces.h:39,
                 from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.h:29,
                 from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:22:
/home/nico/workspace/kdeconnect-kde/interfaces/conversationsinterface.h:45:32: note:   initializing argument 1 of 'QDBusPendingReply<> OrgKdeKdeconnectDeviceConversationsInterface::replyToConversation(const QString&, const QString&)'
     inline QDBusPendingReply<> replyToConversation(const QString &conversationID, const QString &message)
                                ^~~~~~~~~~~~~~~~~~~
/home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp: In member function 'void ConversationModel::requestMoreMessages(const quint32&)':
/home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:88:51: error: invalid user-defined conversion from 'qint32' {aka 'int'} to 'const QString&' [-fpermissive]
     m_conversationsInterface->requestConversation(m_threadId, numMessages, numMessages + howMany);
                                                   ^~~~~~~~~~
In file included from /usr/include/qt/QtCore/qhashfunctions.h:44,
                 from /usr/include/qt/QtCore/qlist.h:47,
                 from /usr/include/qt/QtCore/qvariant.h:45,
                 from /usr/include/qt/QtCore/qabstractitemmodel.h:43,
                 from /usr/include/qt/QtGui/qstandarditemmodel.h:44,
                 from /usr/include/qt/QtGui/QStandardItemModel:1,
                 from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.h:25,
                 from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:22:
/usr/include/qt/QtCore/qstring.h:693:31: note: candidate is: 'QString::QString(const char*)' <near match>
     inline QT_ASCII_CAST_WARN QString(const char *ch)
                               ^~~~~~~
/usr/include/qt/QtCore/qstring.h:693:31: note:   conversion of argument 1 would be ill-formed:
/home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:88:51: error: invalid conversion from 'qint32' {aka 'int'} to 'const char*' [-fpermissive]
     m_conversationsInterface->requestConversation(m_threadId, numMessages, numMessages + howMany);
                                                   ^~~~~~~~~~
/home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:88:51: error: invalid conversion from 'qint32' {aka 'int'} to 'const char*' [-fpermissive]
In file included from /usr/include/qt/QtCore/qhashfunctions.h:44,
                 from /usr/include/qt/QtCore/qlist.h:47,
                 from /usr/include/qt/QtCore/qvariant.h:45,
                 from /usr/include/qt/QtCore/qabstractitemmodel.h:43,
                 from /usr/include/qt/QtGui/qstandarditemmodel.h:44,
                 from /usr/include/qt/QtGui/QStandardItemModel:1,
                 from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.h:25,
                 from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:22:
/usr/include/qt/QtCore/qstring.h:693:51: note:   initializing argument 1 of 'QString::QString(const char*)'
     inline QT_ASCII_CAST_WARN QString(const char *ch)
                                       ~~~~~~~~~~~~^~
In file included from /home/nico/workspace/kdeconnect-kde/interfaces/dbusinterfaces.h:39,
                 from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.h:29,
                 from /home/nico/workspace/kdeconnect-kde/smsapp/conversationmodel.cpp:22:
/home/nico/workspace/kdeconnect-kde/interfaces/conversationsinterface.h:58:32: note:   initializing argument 1 of 'QDBusPendingReply<> OrgKdeKdeconnectDeviceConversationsInterface::requestConversation(const QString&, int, int)'
     inline QDBusPendingReply<> requestConversation(const QString &conversationID, int start, int end)</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R224 KDE Connect</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16475">https://phabricator.kde.org/D16475</a></div></div><br /><div><strong>To: </strong>sredman, KDE Connect, nicolasfella<br /><strong>Cc: </strong>apol, nicolasfella, kdeconnect, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara<br /></div>