D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown

Erik Duisters noreply at phabricator.kde.org
Wed Nov 28 18:46:16 GMT 2018


eduisters added inline comments.

INLINE COMMENTS

> apol wrote in kdeconnect-cli.cpp:168
>   for (const QVariant &variant : qAsConst(urls)) {

I don't know why I used QVariant here (probably because I was fighting with msg.setArguments for a while). I assume that using for (const QString &url : qAsConst(urls)) is  ok as well?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D17081

To: eduisters, #kde_connect, nicolasfella
Cc: apol, nicolasfella, broulik, kdeconnect, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181128/1b86eb4e/attachment.html>


More information about the KDEConnect mailing list