D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown

Aleix Pol Gonzalez noreply at phabricator.kde.org
Wed Nov 28 14:59:31 GMT 2018


apol added a comment.


  Other than that, LGTM.

INLINE COMMENTS

> kdeconnect-cli.cpp:168
> +        
> +            for (QVariant variant : urls) {
> +                QTextStream(stdout) << i18n("Shared %1", variant.toUrl().toString()) << endl;

for (const QVariant &variant : qAsConst(urls)) {

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D17081

To: eduisters, #kde_connect, nicolasfella
Cc: apol, nicolasfella, broulik, kdeconnect, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181128/dc63e117/attachment.html>


More information about the KDEConnect mailing list