D17126: Privacy Options for Notifications Forwarded to Desktop

[Simon Redman]

sredman added a comment.


  This is looking really good! I noticed that there seems to be a problem with the privacy options not being per-connection. I hid the contents for Gmail on my computer at home, but now Gmail contents are blocked on my work computer as well! Do you have some way to test with two desktop devices? I can look in to this as well, but I will not have time for at least a week, probably longer

INLINE COMMENTS

> alexkovrigin wrote in AppDatabase.java:177-191
> I added comments. I don't thing, that idea with two booleans are good, because back when I wrote this code, I focused, so if someone wants to add a new option, for example, to ignore all notification of the app ( for example if it's Facebook messenger xD ). With just an integer the code isn't that easy, but all you have to do is to add a new enum value and that's it. With two booleans it wouldn't be much harder actually... but where's the fun in that? (I guess...)

Okay, sounds fair to me

> alexkovrigin wrote in NotificationsPlugin.java:262-264
> I guess, I did what you said...

Sorry, I was unclear. Does the packet need any of these fields set? Does it work to just leave off "ticker" and "title", rather than assign them to empty strings?

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D17126

To: alexkovrigin, sredman, #kde_connect
Cc: sredman, alexkovrigin, kdeconnect, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181127/2057403e/attachment.html>