D16962: Add mute button with dynamic icon to MPRIS volume control

[Billy Laws]

blaws added inline comments.

INLINE COMMENTS

> broulik wrote in mpris.qml:36
> You could also add a `if (volume == 0) { return "audio-volume-muted" }` and save the `muted` check below :)

Nope, as 0 doesn't always mean muted

> broulik wrote in mpris.qml:125
>   Button {
>       ...
>       icon.name: muted ? "audio-volume-muted" : soundState(root.pluginInterface.volume)
>       ...
>   }
> 
> as well as
> 
>   Slider {
>       ...
>       enabled: !muted
>       ...
>   }
> 
> and then just keep
> 
>   onClicked: {
>       muted = !muted
>       root.pluginInterface.volume = muted ? 0 : volumeUnmuted
>   }

The setting icon name as property in button also fails, maybe qml doesnt check as isnt direct variable

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16962

To: blaws, #kde_connect
Cc: broulik, albertvaka, nicolasfella, kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181120/78659157/attachment.html>