D16962: Add mute button with dynamic icon to MPRIS volume control

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Nov 20 08:08:54 GMT 2018


broulik added inline comments.

INLINE COMMENTS

> mpris.qml:36
> +    {
> +        if (volume <= 25) {
> +            return "audio-volume-low"

You could also add a `if (volume == 0) { return "audio-volume-muted" }` and save the `muted` check below :)

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16962

To: blaws, #kde_connect
Cc: broulik, albertvaka, nicolasfella, kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181120/dc8106ec/attachment.html>


More information about the KDEConnect mailing list