D16599: [Desktop] Make message syncronization interface capable of handling future changes

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Nov 12 15:53:47 GMT 2018


apol added a comment.


  Other than that, let's get this in.

INLINE COMMENTS

> sredman wrote in conversationmessage.h:95
> The reason for not "isTextMessage" is because you could have a picture message which also contains text, so saying "isTextMessage" would technically be not true. The message I am trying to get across with "containsPureText" is that the message contains something which can be directly displayed, as opposed to HTML or some other weirdness. I could change it to something like "containsTextBody" or something if you like that better

I like containsTextBody more, yes.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16599

To: sredman, #kde_connect
Cc: apol, kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, mikesomov, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181112/00ffa51a/attachment.html>


More information about the KDEConnect mailing list