D16797: Fix some android device cannot be found

[Nicolas Fella]

nicolasfella requested changes to this revision.
nicolasfella added a comment.
This revision now requires changes to proceed.


  Thanks for the patch! I noticed some connectivity issues myself so I'm very interested in seeing if this improves the situation for me. I will test it over the next few days.
  
  However, there are some things that need to be improved:
  
  - This needs the permission ACCESS_WIFI_STATE or else it crashes for me
  - You removed the add-by-IP handling, please add it again
  - Not all broadcast addresses end with .255, for example 192.168.0.1 with netmask 255.255.255.128 has 192.168.0.127 as broadcast address. You should be able to get the broadcast address from the NetworkInterface object (https://stackoverflow.com/a/9912504)

REVISION DETAIL
  https://phabricator.kde.org/D16797

To: xiaow, #kde_connect, nicolasfella
Cc: nicolasfella
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181110/9c9a2a17/attachment.html>