D16599: [Desktop] Make message syncronization interface capable of handling future changes

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Nov 2 23:27:11 GMT 2018


apol added inline comments.

INLINE COMMENTS

> conversationmessage.h:95
>  
> +    bool containsPureText() const { return (eventField() & ConversationMessage::EventTextMessage); }
> +

How about `isTextMessage`?
Pure reads weird.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16599

To: sredman, #kde_connect
Cc: apol, kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20181102/1ed9ca41/attachment.html>


More information about the KDEConnect mailing list