D9690: Add contacts-reading plugin (Android side)

Philip Cohn-Cort noreply at phabricator.kde.org
Thu May 17 18:01:38 UTC 2018


philipc added inline comments.

INLINE COMMENTS

> ContactsHelper.java:117
>              output = new Base64OutputStream(encodedPhoto, Base64.DEFAULT);
>              input = context.getContentResolver().openInputStream(photoUri);
>              byte[] buffer = new byte[1024];

Couldn't we create these two streams in a try-with-resources block? I believe Android Studio has a quick fix for that

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D9690

To: sredman, #kde_connect, mtijink
Cc: philipc, kdeconnect, nicolasfella, andyholmes, mtijink, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180517/e2997045/attachment.html>


More information about the KDEConnect mailing list