<table><tr><td style="">philipc added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9690">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9690#inline-66815">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ContactsHelper.java:117</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">output</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">Base64OutputStream</span><span style="color: #aa2211">(</span><span class="n">encodedPhoto</span><span style="color: #aa2211">,</span> <span class="n">Base64</span><span style="color: #aa2211">.</span><span style="color: #354bb3">DEFAULT</span><span style="color: #aa2211">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">input</span> <span style="color: #aa2211">=</span> <span class="n">context</span><span style="color: #aa2211">.</span><span style="color: #354bb3">getContentResolver</span><span style="color: #aa2211">().</span><span style="color: #354bb3">openInputStream</span><span style="color: #aa2211">(</span><span class="n">photoUri</span><span style="color: #aa2211">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">byte</span><span style="color: #aa2211">[]</span> <span class="n">buffer</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span style="color: #aa4000">byte</span><span style="color: #aa2211">[</span><span style="color: #601200">1024</span><span style="color: #aa2211">];</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Couldn't we create these two streams in a try-with-resources block? I believe Android Studio has a quick fix for that</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9690">https://phabricator.kde.org/D9690</a></div></div><br /><div><strong>To: </strong>sredman, KDE Connect, mtijink<br /><strong>Cc: </strong>philipc, kdeconnect, nicolasfella, andyholmes, mtijink, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol<br /></div>