D9691: Add contacts-reading plugin (KDE side)

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  Some nitpicking... looking much better.
  Please extrapolate the comments to similar situations.

INLINE COMMENTS

> contactsplugin.cpp:71
> +        return this->handleResponseUIDsTimestamps(np);
> +    } else if (np.type() == PACKET_TYPE_CONTACTS_RESPONSE_VCARDS)
> +    {

in KDE Connect we don't add a new line after the if:
`} else if () {`

Fix others too.

> contactsplugin.cpp:102
> +
> +    QStringList uIDs = np.get<QStringList>("uids");
> +

mark uIDs const

> contactsplugin.cpp:109
> +    //  If the contact is in local storage, compare its timestamp. If different, request the contact
> +    for (QString ID : uIDs)
> +    {

const QString & ID

> contactsplugin.cpp:180
> +    // Loop over all IDs, extract the VCard from the packet and write the file
> +    for (auto ID : uIDs)
> +    {

auto &

> contactsplugin.h:80
> +
> +typedef qint64 uID_t;
> +

How about:

  typedef qint64 UID;
  
  typedef QList<uID_t> uIDList_t;

> contactsplugin.h:144
> +    */
> +    bool sendRequest(QString packetType);
> +

const QString &

> contactsplugin.h:154
> +     */
> +    bool sendRequestWithIDs(QString packetType, uIDList_t uIDs);
> +};

const QString & and uIDs

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D9691

To: sredman, #kde_connect, apol
Cc: mtijink, #kde_connect, apol, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180328/42ebb904/attachment.html>