D11459: [WIP] Add plugins for controlling local & remote screen brightness

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> brightnessplugin.cpp:61
> +    if (np.has(QStringLiteral("requestBrightness"))) {
> +        NetworkPacket np(PACKET_TYPE_BRIGHTNESS, QVariantMap {
> +            {"brightness", QVariant::fromValue<int>(iface()->brightness())},

You can use np.set<T>(key, value), no need to squeeze everything in a QVariantMap

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D11459

To: kossebau, #kde_connect
Cc: nicolasfella, broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180318/41fbfbed/attachment.html>