D11418: Clean-up requirements: cmake 3.0, qt 5.7, use min versions, deduplicate KF5

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Sat Mar 17 18:00:06 UTC 2018


kossebau created this revision.
kossebau added a reviewer: KDE Connect.
kossebau requested review of this revision.

REVISION SUMMARY
  - cmake 2.8.12 is really outdated, 3.0 is minimum in plasma & kf5
  - cmake_minimum_required should be at begin of toplevel CMakeLists.txt
  - with ecm being part of kf5 since early versions, share ${KF5_MIN_VERSION}
  - use QT_MIN_VERSION & KF5_MIN_VERSION also for separate find_package calls
  - deduplicate all KF5 components searched for in unconditionally included subdirs

TEST PLAN
  Still configures and builds with all options OFF & ON

REPOSITORY
  R224 KDE Connect

BRANCH
  brushoverbuildssystem

REVISION DETAIL
  https://phabricator.kde.org/D11418

AFFECTED FILES
  CMakeLists.txt
  app/CMakeLists.txt
  core/CMakeLists.txt
  daemon/CMakeLists.txt
  fileitemactionplugin/CMakeLists.txt
  indicator/CMakeLists.txt
  kcm/CMakeLists.txt
  kcmplugin/CMakeLists.txt
  kio/CMakeLists.txt
  plugins/battery/CMakeLists.txt
  plugins/mousepad/CMakeLists.txt
  plugins/notifications/CMakeLists.txt
  plugins/pausemusic/CMakeLists.txt
  plugins/ping/CMakeLists.txt
  plugins/screensaver-inhibit/CMakeLists.txt
  plugins/sendnotifications/CMakeLists.txt
  plugins/sftp/CMakeLists.txt
  plugins/share/CMakeLists.txt
  plugins/telephony/CMakeLists.txt
  tests/CMakeLists.txt

To: kossebau, #kde_connect
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180317/5db2d8ac/attachment.html>


More information about the KDEConnect mailing list