<table><tr><td style="">kossebau created this revision.<br />kossebau added a reviewer: KDE Connect.<br />kossebau requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11418">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">cmake 2.8.12 is really outdated, 3.0 is minimum in plasma & kf5</li>
<li class="remarkup-list-item">cmake_minimum_required should be at begin of toplevel CMakeLists.txt</li>
<li class="remarkup-list-item">with ecm being part of kf5 since early versions, share ${KF5_MIN_VERSION}</li>
<li class="remarkup-list-item">use QT_MIN_VERSION & KF5_MIN_VERSION also for separate find_package calls</li>
<li class="remarkup-list-item">deduplicate all KF5 components searched for in unconditionally included subdirs</li>
</ul></div></div><br /><div><strong>TEST PLAN</strong><div><p>Still configures and builds with all options OFF & ON</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R224 KDE Connect</div></div></div><br /><div><strong>BRANCH</strong><div><div>brushoverbuildssystem</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11418">https://phabricator.kde.org/D11418</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
app/CMakeLists.txt<br />
core/CMakeLists.txt<br />
daemon/CMakeLists.txt<br />
fileitemactionplugin/CMakeLists.txt<br />
indicator/CMakeLists.txt<br />
kcm/CMakeLists.txt<br />
kcmplugin/CMakeLists.txt<br />
kio/CMakeLists.txt<br />
plugins/battery/CMakeLists.txt<br />
plugins/mousepad/CMakeLists.txt<br />
plugins/notifications/CMakeLists.txt<br />
plugins/pausemusic/CMakeLists.txt<br />
plugins/ping/CMakeLists.txt<br />
plugins/screensaver-inhibit/CMakeLists.txt<br />
plugins/sendnotifications/CMakeLists.txt<br />
plugins/sftp/CMakeLists.txt<br />
plugins/share/CMakeLists.txt<br />
plugins/telephony/CMakeLists.txt<br />
tests/CMakeLists.txt</div></div></div><br /><div><strong>To: </strong>kossebau, KDE Connect<br /></div>