D10703: Build kdeconnect on sailfish and port some simple plugins

Albert Vaca Cintora noreply at phabricator.kde.org
Thu Mar 15 18:59:43 UTC 2018


albertvaka added inline comments.

INLINE COMMENTS

> CMakeLists.txt:10
> +if(NOT SAILFISHOS)
> +    add_subdirectory(clipboard)
> +    add_subdirectory(share)

Isn't clipboard sync working out of the box? It just uses QClipboard, which should be there in SFOS.

> notificationsdbusinterface.cpp:34
> +//In older Qt released, qAsConst isnt available
> +#if QT_VERSION < QT_VERSION_CHECK(5,7,0)
> +#include "qtcompat_p.h"

Inside qtcompat this is already checked, don't do it again.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D10703

To: piggz, #kde_connect, apol, mtijink
Cc: albertvaka, kossebau, mtijink, vonreth, apol, #kde_connect, nicolasfella, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180315/e5cfa992/attachment.html>


More information about the KDEConnect mailing list