D10703: Build kdeconnect on sailfish and port some simple plugins

[Aleix Pol Gonzalez]

apol added a comment.


  I'm really concerned about how this is removing compilation of most plugins for sailfish. This means that this whole dance will be needed there once more for each plugin.

INLINE COMMENTS

> CMakeLists.txt:33
>  
> -add_definitions(-DQT_NO_URL_CAST_FROM_STRING -DQT_NO_KEYWORDS)
> -

Why?

> daemon.cpp:44
> +#if QT_VERSION < 0x050700
> +#include "qasconst.h"
> +#endif

You may be interested in this:
https://cgit.kde.org/kdevelop.git/tree/kdevplatform/qtcompat_p.h

> notificationsmodel.cpp:34
> +#ifdef SAILFISHOS
> +#define qAsConst
> +#endif

Use your fancy header?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D10703

To: piggz, #kde_connect, apol, mtijink
Cc: kossebau, mtijink, vonreth, apol, #kde_connect, nicolasfella, vhyvert, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, aboudhar, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180304/5d6278aa/attachment-0001.html>