D10703: Build kdeconnect on sailfish and port some simple plugins

[Adam Pigg]

piggz marked 5 inline comments as done.
piggz added inline comments.

INLINE COMMENTS

> mtijink wrote in CMakeLists.txt:24
> Is there a reason you didn't add `-DQT_NO_KEYWORDS`?

Yes, the nemo notification library uses signal/slot terminology instead of Q_SIGNAL/Q_SLOT

> mtijink wrote in sendnotificationsplugin.cpp:29
> Why is this separate file needed?

It is just so that on sfos I can set the plugin to be enabled by default.  Is there a better way?

> mtijink wrote in kdeconnect-sfos.desktop:12
> This line shouldn't be here, right?

It is part of the default template, but ive commented it out.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D10703

To: piggz, #kde_connect, apol, mtijink
Cc: kossebau, mtijink, vonreth, apol, #kde_connect, nicolasfella, vhyvert, adeen-s, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, aboudhar, seebauer, bugzy, MayeulC, menasshock, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180303/4dfe2718/attachment.html>