D12507: Added runcommandplugin widget

Nicolas Fella noreply at phabricator.kde.org
Wed Jun 20 06:58:29 UTC 2018


nicolasfella added inline comments.

INLINE COMMENTS

> RunCommandWidgetDataProviderService.java:12
> +    @Override
> +    public RemoteViewsFactory onGetViewFactory( Intent intent ){
> +

Coding style, no spaces inside parentheses

> RunCommandWidgetDeviceSelector.java:31
> +
> +            final ArrayList<ListAdapter.Item> commandItems = new ArrayList<>();
> +

deviceItems

> RunCommandWidgetDeviceSelector.java:33
> +
> +            for (Device device : service.getDevices().values()) {
> +                commandItems.add(

I think we should filter out devices that are not paired

REVISION DETAIL
  https://phabricator.kde.org/D12507

To: menasshock, albertvaka, #kde_connect, nicolasfella
Cc: kdeconnect, nicolasfella, daniel.z.tg, jeanv, MayeulC, menasshock, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180620/757fa4f7/attachment-0001.html>


More information about the KDEConnect mailing list