<table><tr><td style="">nicolasfella added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12507">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12507#inline-71341">View Inline</a><span style="color: #4b4d51; font-weight: bold;">RunCommandWidgetDataProviderService.java:12</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa22ff">@Override</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">public</span> <span class="n">RemoteViewsFactory</span> <span style="color: #004012">onGetViewFactory</span><span style="color: #aa2211">(</span> <span class="n">Intent</span> <span class="n">intent</span> <span style="color: #aa2211">){</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Coding style, no spaces inside parentheses</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12507#inline-71340">View Inline</a><span style="color: #4b4d51; font-weight: bold;">RunCommandWidgetDeviceSelector.java:31</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">final</span> <span class="n">ArrayList</span><span style="color: #aa2211"><</span><span class="n">ListAdapter</span><span style="color: #aa2211">.</span><span style="color: #354bb3">Item</span><span style="color: #aa2211">></span> <span class="n">commandItems</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">ArrayList</span><span style="color: #aa2211"><>();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">deviceItems</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12507#inline-71339">View Inline</a><span style="color: #4b4d51; font-weight: bold;">RunCommandWidgetDeviceSelector.java:33</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">for</span> <span style="color: #aa2211">(</span><span class="n">Device</span> <span class="n">device</span> <span style="color: #aa2211">:</span> <span class="n">service</span><span style="color: #aa2211">.</span><span style="color: #354bb3">getDevices</span><span style="color: #aa2211">().</span><span style="color: #354bb3">values</span><span style="color: #aa2211">())</span> <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">commandItems</span><span style="color: #aa2211">.</span><span style="color: #354bb3">add</span><span style="color: #aa2211">(</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think we should filter out devices that are not paired</p></div></div></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12507">https://phabricator.kde.org/D12507</a></div></div><br /><div><strong>To: </strong>menasshock, albertvaka, KDE Connect, nicolasfella<br /><strong>Cc: </strong>kdeconnect, nicolasfella, daniel.z.tg, jeanv, MayeulC, menasshock, apol<br /></div>