D9548: Use minSdk in NotificationsPlugin

[Matthijs Tijink]

mtijink accepted this revision.
mtijink added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> nicolasfella wrote in NotificationsPlugin.java:462
> As far as I understand the Annotation is just to suppress warnings/show developers that a specific version is needed. We have to make sure ourself that replyToNotification isn't called.
> 
> Correct me if I'm wrong

You're right, the phabricator diff viewer was a bit unclear to me.

> nicolasfella wrote in NotificationsPlugin.java:574
> NotificationListenerService requires 18/JELLY_BEAN_MR2, without this the whole Plugin doesn't make much sense. 20/KITKAT_WATCH is only needed for the reply feature

Ah, I got confused with alphabetical ordering 😅

REPOSITORY
  R225 KDE Connect - Android application

BRANCH
  noti_minsdk

REVISION DETAIL
  https://phabricator.kde.org/D9548

To: nicolasfella, #kde_connect, mtijink
Cc: mtijink, #kde_connect, SemperPeritus, ahmedbesbes, daniel.z.tg, jeanv, tfella, aboudhar, seebauer, bugzy, progwolff, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180103/73c2b318/attachment-0001.html>